mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 60598: Replaced `abort()` with `_exit()` in `ChildHook::SUPERVISOR`.
Date Wed, 12 Jul 2017 02:06:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60598/#review180271
-----------------------------------------------------------



Bad patch!

Reviews applied: [60598, 60704]

Failed command: python support/apply-reviews.py -n -r 60598

Error:
error: patch failed: 3rdparty/libprocess/src/subprocess.cpp:173
error: 3rdparty/libprocess/src/subprocess.cpp: patch does not apply

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/134/console

- Mesos Reviewbot Windows


On July 11, 2017, 9:24 a.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60598/
> -----------------------------------------------------------
> 
> (Updated July 11, 2017, 9:24 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, Benjamin Bannier, Benjamin
Mahler, and James Peach.
> 
> 
> Bugs: MESOS-7775
>     https://issues.apache.org/jira/browse/MESOS-7775
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously, `abort()` was called in `SUPERVISOR` hook when child
> process exited with an error code, or `waitpid()` failed, or parent
> process exited. All these cases shouldn't lead to abnormal program
> termination with coredumps.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/subprocess.cpp 0f1532b294d6d6b1e017468cfde47362f3faa84d 
> 
> 
> Diff: https://reviews.apache.org/r/60598/diff/3/
> 
> 
> Testing
> -------
> 
> make check (mac os x, fedora 25)
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message