mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 59764: Ignore registration attempts by agents with misconfigured domain.
Date Tue, 11 Jul 2017 17:14:42 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59764/
-----------------------------------------------------------

(Updated July 11, 2017, 5:14 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Address review comment.


Bugs: MESOS-7612
    https://issues.apache.org/jira/browse/MESOS-7612


Repository: mesos


Description
-------

We expect the master's domain to be configured first, then the domain of
the agents to be configured. Therefore, if an agent with configured
domain attempts to register or re-register with a master that does not
have a configured domain, the registration attempt should be ignored.
This is important, because the master would have no way of determining
whether the agent is "remote" or not, which might result in placing
inappropriate workloads on it.


Diffs (updated)
-----

  src/master/master.cpp 7668749cc4658627ed3bdd6cdcf7e837daece8d6 
  src/tests/master_tests.cpp 9cfa510f1e5742b47a44cb640a0d6ba85a2880ae 


Diff: https://reviews.apache.org/r/59764/diff/5/

Changes: https://reviews.apache.org/r/59764/diff/4-5/


Testing
-------

`make check`

Manual testing.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message