mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Avinash sridharan <>
Subject Re: Review Request 60720: Fixed initialization of `__address__` in the abscense of `--ip` flag.
Date Sat, 08 Jul 2017 00:08:29 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 8, 2017, 12:08 a.m.)

Review request for mesos and Jiang Yan Xu.


Added a description about the tests as well.

Bugs: MESOS-7769

Repository: mesos


When we introduced the `__address6__ optional IPv6 storage into
`libprocess` we also introduced a regression because of which the `port`
doesn't get initialized to whatever is specified in the `--port` flag
until the `--ip` flag is specified.

This change fixes the initialization of the `__address__` in the
absence of the `--ip` flag.


  3rdparty/libprocess/src/process.cpp 264298c16199ded4ccbf948f6893f4209c23aed0 


Testing (updated)

sudo ./build/bin/  --port=5059 --master= --work_dir=/tmp/mesos
tcp        0      0  *               LISTEN

sudo ./build/bin/  --ip= --port=5059 --master= --work_dir=/tmp/mesos
tcp        0      0*               LISTEN


Avinash sridharan

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message