mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Quinn Leng <>
Subject Re: Review Request 60716: Cleaned up authentication acceptor to have one class.
Date Fri, 07 Jul 2017 22:25:06 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 7, 2017, 10:25 p.m.)

Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.

Bugs: MESOS-7630

Repository: mesos

Description (updated)

Cleaned up authentication acceptor to have one class.

Replace different Authorization related Acceptor classes with one
AuthorizationAcceptor class.

Single static create function for AuthorizationAcceptor, single
acceptor function accepting ObjectApprover::Object.

Templated 'accept' function to take different number and types of

Removed ObjectAcceptor parent class, since no inheritance feature
provided by it.

Diffs (updated)

  src/common/http.hpp b7e4a8adcbcaa3a962af795c67694a35161b6c1a 
  src/common/http.cpp fdb591eccf273260902f3f695cf431f72ee3d817 
  src/master/http.cpp 175a44ce7fb5be509453c25eaa9ec29f35adba3a 




Passed "make check -j48"
Passed 'GTEST_FILTER="MasterTest.TasksEndpoint" make check -j48'


Quinn Leng

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message