mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <>
Subject Re: Review Request 60638: Changed semantics of allocator 'updateSlave' method.
Date Fri, 07 Jul 2017 08:54:29 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated July 7, 2017, 10:54 a.m.)

Review request for mesos, Benjamin Mahler, Jie Yu, and Jan Schlicht.


Added optimization for cases where new total == old total.

Bugs: MESOS-7755

Repository: mesos

Description (updated)

We change the semantics of the 'updateSlave' method present in the
allocator interface. While previously the passed optional resource
argument was interpreted as the amount of (new) oversubscribed
resources, it now represents the new amount of total resources on the
given agent.

We addtionally add an optimization of
'HierarchicalAllocatorProcess::updateSlaveTotal' for cases where the
passed total is identical to the current total. This operation is a
no-op now and we prevent updating the sorters.

Diffs (updated)

  include/mesos/allocator/allocator.hpp bec9e0b8ef8d51ec22f9e8af69407ed5ecaa3e8f 
  src/master/allocator/mesos/allocator.hpp 2e780c92d5c5132abff32f1ce051c3bab2947f37 
  src/master/allocator/mesos/hierarchical.hpp 5c58cf401de9205e54300e0ce8433995cdf5cb7a 
  src/master/allocator/mesos/hierarchical.cpp eb01d8e6b1108866ebc049f9f4a46157823a3541 
  src/master/master.cpp 56b170ed70722eba30d98f6e648b6a31580d6b56 
  src/tests/hierarchical_allocator_tests.cpp 2a312a9af4bae679a0a4e7bf45a3c013513c5da2 




Tested with


Benjamin Bannier

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message