mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Quinn Leng <quinn.leng....@gmail.com>
Subject Review Request 60581: Added filtering to the '/slaves' endpoint.
Date Fri, 30 Jun 2017 22:35:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60581/
-----------------------------------------------------------

Review request for mesos, Anand Mazumdar, Alexander Rojas, Greg Mann, and Vinod Kone.


Bugs: MESOS-7630
    https://issues.apache.org/jira/browse/MESOS-7630


Repository: mesos


Description
-------

Added filtering to the '/slaves' endpoint.

Add query parameter support for that endpoint,
to get the information of one slave, we can use
'slave_id' as the query parameter. Thus it looks 
like '/slaves?slave_id=[slave id]'

When no slave_id is specified, it will return
information of all slaves.

The structure for the response is reserved, thus
even if slave_id is specified, the structure for
response still contains field 'slaves' and
'recovered_slaves' etc..


Diffs
-----

  src/common/http.hpp 93d6088e97c2384f9f6d26e010a501abf2deb43e 
  src/common/http.cpp 2f7718cbc2e449b4f7c89754e8f84eac2f3c35b6 
  src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
  src/tests/.master_tests.cpp.swp PRE-CREATION 
  src/tests/master_tests.cpp 6cd4be7e5ba48c6562ce91b28e76b065522cfbea 


Diff: https://reviews.apache.org/r/60581/diff/1/


Testing
-------

Passed 'make check -j48'
Passed 'GTEST_FILTER="MasterTest.SlavesEndpointQuerySlave" make check -j48'
Passed 'GLOG_v=1 ./bin/mesos-tests.sh --gtest_filter="MasterTest.SlavesEndpointQuerySlave"
--gtest_repeat=1000 --gtest_break_on_failure'


Thanks,

Quinn Leng


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message