mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 60566: Validated and upgraded resources on the V1 operator API path.
Date Fri, 30 Jun 2017 19:44:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60566/#review179403
-----------------------------------------------------------




src/tests/master_tests.cpp
Lines 7695 (patched)
<https://reviews.apache.org/r/60566/#comment254083>

    Let's not depend on master implementation details here just to get the `SlaveID`, instead
just intercept the `SlaveRegistrationMessage` like below.



src/tests/master_tests.cpp
Lines 7797 (patched)
<https://reviews.apache.org/r/60566/#comment254084>

    Ditto.


- Benjamin Bannier


On June 30, 2017, 2:56 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60566/
> -----------------------------------------------------------
> 
> (Updated June 30, 2017, 2:56 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
>   src/master/master.hpp 9dd6a530c373516dc81bfd51ee6e95f25588148f 
>   src/tests/master_tests.cpp cfb799fd105e9880cd56415b2a84e604c8f62703 
>   src/tests/persistent_volume_endpoints_tests.cpp 518bdf858096ec9bcfa4f899ead5a6c3d103c521

>   src/tests/reservation_endpoints_tests.cpp f710a188a7875c1cb847e39276b4b65332703ca5

> 
> 
> Diff: https://reviews.apache.org/r/60566/diff/1/
> 
> 
> Testing
> -------
> 
> Added new tests + `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message