mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Review Request 60562: Updated `accept` to perform operation adjustment in one place.
Date Fri, 30 Jun 2017 09:01:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60562/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-7735
    https://issues.apache.org/jira/browse/MESOS-7735


Repository: mesos


Description
-------

It used to be that the minor adjustments that were made to operations
were done in various places across `accept` and `_accept`.

The "executor-injection" for LAUNCH_GROUP was at the beginning of
`accept`, "allocation-info-injection" for MULTI_ROLE was after offer
validation, and "health-check-injection" for LAUNCH was in `_accept`.

The `Master::accept` function is now broken down into distinct
"metrics accounting", "offer validation", "operation-adjustments", and
"authorization" stages.


Diffs
-----

  src/master/master.cpp 276b18e4d1bab7e9b28c1c93fe13c93a38abc5cd 


Diff: https://reviews.apache.org/r/60562/diff/1/


Testing
-------

`make check`


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message