mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hao Yixin <haoyi...@360.cn>
Subject Re: Review Request 60170: Supported auto cgroups in unified cgroup isolator.
Date Tue, 27 Jun 2017 03:04:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60170/#review178946
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp
Lines 323 (patched)
<https://reviews.apache.org/r/60170/#comment253330>

    I think that "cgroups/*" is more semantically consistent.


- Hao Yixin


On 六月 26, 2017, 10:39 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60170/
> -----------------------------------------------------------
> 
> (Updated 六月 26, 2017, 10:39 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Hao Yixin, Jason Lai, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7691
>     https://issues.apache.org/jira/browse/MESOS-7691
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch introduced a new agent isolation option 'cgroups', which
> represents all local machine supported cgroup subsystems will be
> turned on automatically.
> 
> Note that if this 'cgroups' option is specified in isolation, all
> other specified cgroup subsystems will be included.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.cpp 9376d14d66f5dc7e91c7c0e9da253f5eb9347539

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp d7a95b2d49fd2ae743e2bffc25f15c4ce4b96f39

> 
> 
> Diff: https://reviews.apache.org/r/60170/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message