mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 60448: Forward declare CheckerProcess.
Date Mon, 26 Jun 2017 22:31:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60448/#review178934
-----------------------------------------------------------


Ship it!




Ship It!

- Gastón Kleiman


On June 26, 2017, 10:18 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60448/
> -----------------------------------------------------------
> 
> (Updated June 26, 2017, 10:18 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rather than including "checker_process.hpp" in header files,
> forward declare CheckerProcess. This results in fewer visible
> symbols and hopefully some small improvement in build times.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker.hpp 6f65b4709a3420fc7f4ed885425cdc8192cbcfbf 
>   src/checks/health_checker.hpp dab366db45b11c6d300e9c8b82ce06565cec85a1 
>   src/checks/health_checker.cpp 26b2dafa1ee6dedee1c2217bcb3c3dcd727be5ef 
> 
> 
> Diff: https://reviews.apache.org/r/60448/diff/1/
> 
> 
> Testing
> -------
> 
> make check (Fedora 26)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message