mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From James Peach <jpe...@apache.org>
Subject Review Request 60448: Forward declare CheckerProcess.
Date Mon, 26 Jun 2017 22:18:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60448/
-----------------------------------------------------------

Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
-------

Rather than including "checker_process.hpp" in header files,
forward declare CheckerProcess. This results in fewer visible
symbols and hopefully some small improvement in build times.


Diffs
-----

  src/checks/checker.hpp 6f65b4709a3420fc7f4ed885425cdc8192cbcfbf 
  src/checks/health_checker.hpp dab366db45b11c6d300e9c8b82ce06565cec85a1 
  src/checks/health_checker.cpp 26b2dafa1ee6dedee1c2217bcb3c3dcd727be5ef 


Diff: https://reviews.apache.org/r/60448/diff/1/


Testing
-------

make check (Fedora 26)


Thanks,

James Peach


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message