mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 60370: Updated agent webui page to display allocated resources per each role.
Date Mon, 26 Jun 2017 17:46:15 GMT


> On June 23, 2017, 4:06 p.m., haosdent huang wrote:
> > src/webui/master/static/agent.html
> > Lines 176 (patched)
> > <https://reviews.apache.org/r/60370/diff/1/?file=1758433#file1758433line176>
> >
> >     Should we use `*` here to keep consistent with other parts?

There is related discussion in the ticket, so it looks like we have agreed on calling it "Unreserved".


> On June 23, 2017, 4:06 p.m., haosdent huang wrote:
> > src/webui/master/static/agent.html
> > Lines 184 (patched)
> > <https://reviews.apache.org/r/60370/diff/1/?file=1758433#file1758433line184>
> >
> >     Is `|| 0` necessary here?

I think yes, because we might miss information about a specific role in state.reserved_resources_allocated.
E.g., we have both statically reserved resources for both "ads" and "dyn" roles, but only
one role is actually allocated. Let's assume that resources from "dyn" role are used to launch
some task, while "ads" role isn't used, hence no item for "ads" in state.reserved_resources_allocated
exists. In the latter case 0 is used as a default value.


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60370/#review178801
-----------------------------------------------------------


On June 22, 2017, 3:26 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60370/
> -----------------------------------------------------------
> 
> (Updated June 22, 2017, 3:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and haosdent huang.
> 
> 
> Bugs: MESOS-6441
>     https://issues.apache.org/jira/browse/MESOS-6441
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated agent webui page to display allocated resources per each role.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/agent.html 71e5e702e5e64e6f46c84791247aa5156c046ed9 
>   src/webui/master/static/js/controllers.js 67bfd030649dd21840c16188a4964f814aa232d7

> 
> 
> Diff: https://reviews.apache.org/r/60370/diff/1/
> 
> 
> Testing
> -------
> 
> See screenshot.
> 
> 
> File Attachments
> ----------------
> 
> agent.html
>   https://reviews.apache.org/media/uploaded/files/2017/06/22/66cc61b4-04c8-451e-a434-58f556397724__Resource_Reservations.png
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message