mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 60234: Linted support/push-commits.py.
Date Mon, 26 Jun 2017 09:46:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60234/#review178875
-----------------------------------------------------------


Fix it, then Ship it!





support/push-commits.py
Lines 20 (patched)
<https://reviews.apache.org/r/60234/#comment253177>

    Could we add a one-line, PEP-257-conformant summary line here?



support/push-commits.py
Line 28 (original), 46 (patched)
<https://reviews.apache.org/r/60234/#comment253178>

    Since we are cleaning up, could we make this PEP257-conformant (this could also make it
fit on a single line), e.g.,
    
        """Return the list of reviews found in the commits in the revision range."""



support/push-commits.py
Line 55 (original), 73 (patched)
<https://reviews.apache.org/r/60234/#comment253179>

    The old wording seemed better to me, but I am not a native speaker. Also, PEP-257 suggests
`s/Marks/Mark/`.



support/push-commits.py
Line 65 (original), 83 (patched)
<https://reviews.apache.org/r/60234/#comment253182>

    Since we are cleaning up, can we make this PEP257-conformant, e.g.,
    
        """Return a dictionary of options parsed from command line arguments."""



support/push-commits.py
Lines 101 (patched)
<https://reviews.apache.org/r/60234/#comment253181>

    Can we add a one-line, PEP257-conformant summary here?


- Benjamin Bannier


On June 20, 2017, 12:15 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60234/
> -----------------------------------------------------------
> 
> (Updated June 20, 2017, 12:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Bugs: MESOS-6390
>     https://issues.apache.org/jira/browse/MESOS-6390
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will allow us to use PyLint on the
> entire support directory in the future.
> 
> 
> Diffs
> -----
> 
>   support/push-commits.py 4835d67393aaf3a38a1da90ccc7c89a952bf9270 
> 
> 
> Diff: https://reviews.apache.org/r/60234/diff/1/
> 
> 
> Testing
> -------
> 
> Added `support` to `source_dirs` in the PyLinter defined
> in `mesos-style.py`. Linted until only acceptable errors
> where displayed (e.g. due to the name of the file containing
> a dash instead of an underscore).
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message