mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 60233: Linted support/post-reviews.py.
Date Mon, 26 Jun 2017 09:40:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60233/#review178874
-----------------------------------------------------------


Fix it, then Ship it!





support/post-reviews.py
Line 20 (original), 20 (patched)
<https://reviews.apache.org/r/60233/#comment253172>

    Can we add a one-line PEP257-conformant summary?



support/post-reviews.py
Lines 37 (patched)
<https://reviews.apache.org/r/60233/#comment253171>

    Let's quote this docstring with `r"""` since we have backslashes here.



support/post-reviews.py
Lines 59 (patched)
<https://reviews.apache.org/r/60233/#comment253169>

    `Execute a process and leave.`, see PEP257.



support/post-reviews.py
Line 48 (original), 69 (patched)
<https://reviews.apache.org/r/60233/#comment253173>

    Do we need to name the exception here? It seems the original `raise` was sufficient.



support/post-reviews.py
Line 55 (original), 76 (patched)
<https://reviews.apache.org/r/60233/#comment253174>

    This pattern seems not straight-forward to me, could we just use a multiline string here,
e.g.,
    
        need_login = 'Please log in to the Review Board' \
                     ' server at reviews.apache.org.'



support/post-reviews.py
Lines 94 (patched)
<https://reviews.apache.org/r/60233/#comment253170>

    Can we add a PEP257-conformant summary line here, e.g.,
    
        Execute main function.



support/post-reviews.py
Line 282 (original), 316 (patched)
<https://reviews.apache.org/r/60233/#comment253175>

    Let's just continue the line with `\`, e.g.,
    
            if rbt_command in post_review and \
               rbt_version >= LooseVersion('RBTools 0.6'):



support/post-reviews.py
Lines 321 (patched)
<https://reviews.apache.org/r/60233/#comment253176>

    Continue with `\`, e.g.,
    
                if rbt_version >= LooseVersion('RBTools 0.6.1') and \
                   parent_review_request_id:


- Benjamin Bannier


On June 20, 2017, 12:15 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60233/
> -----------------------------------------------------------
> 
> (Updated June 20, 2017, 12:15 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Joseph Wu.
> 
> 
> Bugs: MESOS-6390
>     https://issues.apache.org/jira/browse/MESOS-6390
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This will allow us to use PyLint on the
> entire support directory in the future.
> 
> 
> Diffs
> -----
> 
>   support/post-reviews.py 410fb3371a3c46adbfd68c7584ffd6cf3b3010d1 
> 
> 
> Diff: https://reviews.apache.org/r/60233/diff/1/
> 
> 
> Testing
> -------
> 
> Added `support` to `source_dirs` in the PyLinter defined
> in `mesos-style.py`. Linted until only acceptable errors
> where displayed (e.g. due to the name of the file containing
> a dash instead of an underscore).
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message