mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Review Request 60416: Avoided master crash on re-registration of old agents.
Date Sat, 24 Jun 2017 19:42:54 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60416/
-----------------------------------------------------------

Review request for mesos and Adam B.


Repository: mesos


Description
-------

At present, agents that are refinement-capable send their task and
executor resources in the post-refinement format, whereas older agents
use the pre-refinement format. However, the master code only converted
agent resources to post-refinement format if the agent was not
multi-role capable. This leads to a subsequent `CHECK` failure for
agents that have multi-role but not reservation-refinement capabilities.

We should instead convert to post-refinement format for all
non-refinement capable agents.


Diffs
-----

  src/master/master.cpp 33eca0d17459781fdc2ea915e8f40c78dd306962 


Diff: https://reviews.apache.org/r/60416/diff/1/


Testing
-------

`make check`, manual testing.


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message