mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 60407: Avoided master crash on agent re-registration.
Date Sat, 24 Jun 2017 01:47:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60407/
-----------------------------------------------------------

(Updated June 24, 2017, 1:47 a.m.)


Review request for mesos and Michael Park.


Changes
-------

Tweak comment.


Repository: mesos


Description
-------

When validating the agent's ReregisterSlaveMessage, the master's
validation code neglected to account for the fact that the task
resources might not be in post-refinement format (e.g., if the agent
does not support reservation refinement). This lead to a `CHECK` failure
during validation.

Fix this by relaxing the validation of ReregisterSlaveMessage so that we
do not depend on the task resources being in post-refinement
format. This means validation of ReregisterSlaveMessage will be less
effective, but since it is best-effort anyway, this seems tolerable.


Diffs (updated)
-----

  src/master/validation.cpp 33e9ff7db9e2789cbb2d6dfd015288dfa1faa7c5 


Diff: https://reviews.apache.org/r/60407/diff/2/

Changes: https://reviews.apache.org/r/60407/diff/1-2/


Testing
-------

`make check`


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message