mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Megha Sharma <mshar...@apple.com>
Subject Re: Review Request 60105: Clean rebooted slave's state if slaveInfo mismatches.
Date Fri, 23 Jun 2017 21:11:04 GMT


> On June 23, 2017, 6:21 p.m., Jiang Yan Xu wrote:
> > src/slave/slave.cpp
> > Lines 5994-5999 (patched)
> > <https://reviews.apache.org/r/60105/diff/6/?file=1759987#file1759987line5997>
> >
> >     I tweaked it a little bit:
> >     
> >     ```
> >           // Fail the recovery unless the agent is recovering for the first
> >           // time after host reboot.
> >           //
> >           // Prior to Mesos 1.4 we directly bypass the state recovery and
> >           // start as a new agent upon reboot (introduced in MESOS-844).
> >           // This unncessarily discards the existing agent ID (MESOS-6223).
> >           // Starting in Mesos 1.4 we'll attempt to recover the slave state
> >           // even after reboot but in case of slave info mismatch we'll fall
> >           // back to recovering as a new agent (existing behavior). This
> >           // prevents the agent from flapping if the slave info (resources,
> >           // attributes, etc.) change is due to host maintainance associated
> >           // with the reboot.
> >     ```
> >     
> >     What do you think? Feel free to improve on it.

+1, good and concise explanation about the changed behavior.


- Megha


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60105/#review178750
-----------------------------------------------------------


On June 23, 2017, 5:19 p.m., Megha Sharma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60105/
> -----------------------------------------------------------
> 
> (Updated June 23, 2017, 5:19 p.m.)
> 
> 
> Review request for mesos, Neil Conway, Vinod Kone, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-6223
>     https://issues.apache.org/jira/browse/MESOS-6223
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Prior to Mesos 1.4 we bypass the state recovery and
> start as a new agent upon reboot. Starting in Mesos 1.4
> we'll attempt to recover the slave state even after reboot
> except for when there is a SlaveInfo mismatch.
> Here, we cleanup the slave state for a rebooted agent if
> there's been a SlaveInfo mismatch during recovery to
> ensure that no other state is recovered and the
> agent enventually registers as a new agent.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.cpp f808458849bb9667a91abe18868751d377d36e0c 
> 
> 
> Diff: https://reviews.apache.org/r/60105/diff/7/
> 
> 
> Testing
> -------
> 
> make check done together with 60104 and 56895
> 
> 
> Thanks,
> 
> Megha Sharma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message