mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 60329: Windows: Replaced `CreateProcess()` with `create_process()` helper.
Date Wed, 21 Jun 2017 22:12:14 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60329/
-----------------------------------------------------------

Review request for mesos, Alexander Rukletsov, Jeff Coffler, John Kordich, Joseph Wu, Li Li,
and Michael Park.


Bugs: MESOS-6817, MESOS-7371 and MESOS-7407
    https://issues.apache.org/jira/browse/MESOS-6817
    https://issues.apache.org/jira/browse/MESOS-7371
    https://issues.apache.org/jira/browse/MESOS-7407


Repository: mesos


Description
-------

This uses the new `ProcessData create_process()` abstraction added to
stout, reducing the use of the Windows API in libprocess. The
`ProcessData` struct eliminates the need to manually call
`CloseHandle()`.


Diffs
-----

  3rdparty/libprocess/cmake/ProcessConfigure.cmake 2c46d43ed8418f128f12fad10151700611e81b1e

  3rdparty/libprocess/include/process/subprocess_base.hpp a3edae6c37e5336912d92b406d934c58bdf386d9

  3rdparty/libprocess/include/process/windows/subprocess.hpp 5459955fb3b7b07b976ece61bf59bc237896e2de

  3rdparty/libprocess/src/subprocess.cpp 0f1532b294d6d6b1e017468cfde47362f3faa84d 


Diff: https://reviews.apache.org/r/60329/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message