mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 60290: Handle EINVAL from the capabilities version check.
Date Wed, 21 Jun 2017 22:00:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60290/#review178568
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On June 21, 2017, 8:52 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60290/
> -----------------------------------------------------------
> 
> (Updated June 21, 2017, 8:52 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> capget will fail with the error EINVAL, and set the version field
> to the kernel preferred value of _LINUX_CAPABILITY_VERSION_?
> when an unsupported version value is specified.
> 
> So if we get EINVAL, we can treat that as success because we can
> continue to verify the capabilities version.
> 
> 
> Diffs
> -----
> 
>   src/linux/capabilities.cpp b362759c06637a3a2b4359b95e86d6d3b87352dd 
> 
> 
> Diff: https://reviews.apache.org/r/60290/diff/2/
> 
> 
> Testing
> -------
> 
> make check (CentOS 6)
> 
> 
> Thanks,
> 
> James Peach
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message