mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 60293: Windows: Switched from `gethostname` to `GetComputerName`.
Date Wed, 21 Jun 2017 21:51:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60293/
-----------------------------------------------------------

Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.


Bugs: MESOS-6817 and MESOS-7548
    https://issues.apache.org/jira/browse/MESOS-6817
    https://issues.apache.org/jira/browse/MESOS-7548


Repository: mesos


Description
-------

The former can inordinately slow on Windows (about 5 seconds),
whereas the latter is guaranteed to return instantly.

Because `os::internal::nodename()` and `net::hostname()` implemented the
exact same feature, we just reuse the first in the second.


Diffs
-----

  3rdparty/stout/include/stout/net.hpp 425544e1d428b1c65a15221c34c9d29e7dc31f65 
  3rdparty/stout/include/stout/posix/net.hpp 59463a05a62559cea3964c2b058a2205db24fa9b 
  3rdparty/stout/include/stout/windows/net.hpp 987ab7075fe3c1127cab7e14831ca22030c35e45 
  3rdparty/stout/include/stout/windows/os.hpp f1722d5e18af97d89c6ca7aaf002fd58cb0d21ae 


Diff: https://reviews.apache.org/r/60293/diff/1/


Testing
-------


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message