mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 60124: Added a name to ballon framework to distinguish between instances.
Date Wed, 21 Jun 2017 21:46:58 GMT


> On June 15, 2017, 12:07 p.m., Armand Grillet wrote:
> > src/examples/balloon_framework.cpp
> > Line 464 (original), 469 (patched)
> > <https://reviews.apache.org/r/60124/diff/1/?file=1752029#file1752029line469>
> >
> >     Consistency wise, other tests have just `executor.set_name("Framework Name Executor
(C++)");` to set the name of the executor (e.g. in `long_lived_framework.cpp`). More generally,
what is the reason to add a `name` flag for this test?
> 
> Alexander Rukletsov wrote:
>     If we have multiple instance of the same framework, it can be difficult to distinguish
between them in the WebUI, hence this change. I agree, this is not only relevant to this framework,
but actually to all example frameworks.

You might as well let the flag control the entire name, rather than appending `--name` to
the end of `Balloon Framework`.  Or update the flag description to mention that it will be
appended to the canonical framework name.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60124/#review178030
-----------------------------------------------------------


On June 15, 2017, 10:09 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60124/
> -----------------------------------------------------------
> 
> (Updated June 15, 2017, 10:09 a.m.)
> 
> 
> Review request for mesos, Armand Grillet and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/examples/balloon_framework.cpp bfaae3796afb426459ef5cff3a37634a8242032e 
> 
> 
> Diff: https://reviews.apache.org/r/60124/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message