mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jay Guo <guojiannan1...@gmail.com>
Subject Re: Review Request 58099: Added authorization for frameworks in `GetRoles` v1 API.
Date Wed, 21 Jun 2017 18:03:31 GMT


> On May 17, 2017, 4:29 p.m., Adam B wrote:
> > Seems like we're adding even more duplicate code into this v1 clone of `roles()`.
Can you find a way to reduce the redundance?

OK, let me take look and may submit some follow-up patches for it.


- Jay


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58099/#review175219
-----------------------------------------------------------


On June 22, 2017, 2:02 a.m., Jay Guo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58099/
> -----------------------------------------------------------
> 
> (Updated June 22, 2017, 2:02 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rojas, and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7260
>     https://issues.apache.org/jira/browse/MESOS-7260
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added authorization for frameworks in `GetRoles` v1 API.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 4dd43fd7c3fb986f4eed78bce574b6d3af156b67 
>   src/tests/api_tests.cpp cdaa72462eac1687185115771265539d8c2b09a9 
> 
> 
> Diff: https://reviews.apache.org/r/58099/diff/7/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jay Guo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message