mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ian Downes <ian.dow...@gmail.com>
Subject Re: Review Request 59294: Optionally scale egress bandwidth with CPU.
Date Wed, 21 Jun 2017 17:27:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59294/
-----------------------------------------------------------

(Updated June 21, 2017, 10:27 a.m.)


Review request for mesos, Dmitry Zhuk, Ilya Pronin, and Jie Yu.


Changes
-------

Use HTB class introduced in review 60203 to avoid shelling out. Included support for setting
burst rate (ceil) and bucket size (cburst).
This is intentionally still in the model of an egress qdisc inside each container.


Bugs: MESOS-7508
    https://issues.apache.org/jira/browse/MESOS-7508


Repository: mesos


Description
-------

Add support to isolators/port_mapping for optionally scaling egress bandwidth with CPU and
with minimum and maximum limits.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/network/helper.cpp 4ed879dca42f85fc9dd7638e763822cf10fa8405

  src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 9d38289c7161d5e931053b587d115684ccc44c94

  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp cd008aaebcd42554a9a81d2b059269546f59c966

  src/slave/flags.hpp e75c1b4227b443aedf445921b3f2108d930c112c 
  src/slave/flags.cpp c84aa6724170bba46b4444be8410b71d42a1626e 
  src/tests/containerizer/port_mapping_tests.cpp 16e015a8ac53a4aa5336b60c40228720b5f6910a



Diff: https://reviews.apache.org/r/59294/diff/3/

Changes: https://reviews.apache.org/r/59294/diff/2-3/


Testing
-------

# added a new test 
$ make check


Thanks,

Ian Downes


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message