mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 60254: Added missing `RESERVATION_REFINEMENT` capability to examples and tests.
Date Wed, 21 Jun 2017 01:05:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60254/#review178446
-----------------------------------------------------------


Ship it!




Ship It!

- Neil Conway


On June 20, 2017, 11:35 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60254/
> -----------------------------------------------------------
> 
> (Updated June 20, 2017, 11:35 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This is a follow-up to https://reviews.apache.org/r/60073/.
> We missed a few places in root tests and examples which aren't part of
> the test suite.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp 6ab0cb48c9226e66b49580c7c2a2c9af3019d77d 
>   src/examples/balloon_framework.cpp 51b01cfd52d7b353e48e81c7a7dea2222ff6920e 
>   src/examples/docker_no_executor_framework.cpp 657a02a22c457543b39a2eb9df42a2aa70dea756

>   src/examples/load_generator_framework.cpp 7f1ada507eaa010d22b4611744fff89109c42065

>   src/examples/long_lived_framework.cpp bdf20a79a49c987bf34240bb7cb3a53a58097105 
>   src/tests/containerizer/docker_containerizer_tests.cpp 8ac56ed947ad49c46d8a7313bbc568f8fae1d656

> 
> 
> Diff: https://reviews.apache.org/r/60254/diff/1/
> 
> 
> Testing
> -------
> 
> ```bash
> (1) sudo make distcheck
> (2) ./src/mesos-execute --role="ads" --master=127.0.0.1:5050 --name=blah --command="while
true; do : ; done" --resources="mem:1100;cpus:9"
> (3) ./src/long-lived-framework --master=127.0.0.1:5050
> ```
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message