mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <>
Subject Re: Review Request 60253: Placed the `convertResourceFormat` calls after resource validation.
Date Tue, 20 Jun 2017 23:35:53 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated June 20, 2017, 4:35 p.m.)

Review request for mesos and Neil Conway.

Repository: mesos


`Resources` requires that the `Resource` objects being constructed with
be validated and are in the "post-reservation-refinement" format.
The `convertResourceFormat` was previously placed after the validation
of operations, but we construct `Resources` prior to operation
validation. This patch moves the conversion logic earlier to be done
right after resource validation.


  src/master/http.cpp 801b80933985a95d58f6b3b9973558d0c5a4410e 


Testing (updated)

curl -i -d slaveId=9091bf1d-58cb-4f54-b804-fe3eef85facd-S0 -d resources='[{"name":"cpus","type":"SCALAR","scalar":{"value":1},"role":"ads","reservation":{}},{"name":"mem","type":"SCALAR","scalar":{"value":1024},"role":"ads","reservation":{}}]'


Michael Park

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message