mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Review Request 60253: Placed the `convertResourceFormat` calls after resource validation.
Date Tue, 20 Jun 2017 23:35:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60253/
-----------------------------------------------------------

Review request for mesos and Neil Conway.


Repository: mesos


Description
-------

`Resources` requires that the `Resource` objects being constructed with
be validated and are in the "post-reservation-refinement" format.
The `convertResourceFormat` was previously placed after the validation
of operations, but we construct `Resources` prior to operation
validation. This patch moves the conversion logic earlier to be done
right after resource validation.


Diffs
-----

  src/master/http.cpp 801b80933985a95d58f6b3b9973558d0c5a4410e 


Diff: https://reviews.apache.org/r/60253/diff/1/


Testing
-------


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message