mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 60017: Resources: Adjusted the utilities to the new resource format [5/N].
Date Mon, 19 Jun 2017 06:39:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60017/#review178187
-----------------------------------------------------------


Fix it, then Ship it!





src/common/resources.cpp
Line 1501 (original), 1501 (patched)
<https://reviews.apache.org/r/60017/#comment252057>

    Per discussion, should instead result in a statically reserved resource whose role is
the last role in the reservation stack.


- Neil Conway


On June 13, 2017, 8:35 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60017/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 8:35 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Neil Conway.
> 
> 
> Bugs: MESOS-7655
>     https://issues.apache.org/jira/browse/MESOS-7655
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp cc305e64cadc9fab913ede987625fc1839646306 
>   src/common/resources_utils.cpp aca2a0c630164af718007c70197461cebcd10d3e 
>   src/v1/resources.cpp 03d6c8098a24a2751617d14f2664de1d88318414 
> 
> 
> Diff: https://reviews.apache.org/r/60017/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message