mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Re: Review Request 60013: Resources: Updated the validation logic.
Date Thu, 15 Jun 2017 07:39:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60013/
-----------------------------------------------------------

(Updated June 15, 2017, 12:39 a.m.)


Review request for mesos and Benjamin Mahler.


Bugs: MESOS-7655
    https://issues.apache.org/jira/browse/MESOS-7655


Repository: mesos


Description (updated)
-------

This patch updates `Resources::validate`, and `resource::validate`.

The `Resources::validate` function ensures that the resources are
either in the 'pre-' or 'post-' reservation-refinement formats,
but not both.

The `resource::validate` function takes an optional framework
capabilities and ensures that the resources format matches
the framework's RESERVATION_REFINEMENT capbility.


Diffs (updated)
-----

  src/common/resources.cpp 7b3fae1a34150964ba3831a3aef2f868e338aef8 
  src/master/validation.hpp 6b53e34f67f6a8b338b92db6cb7398f1dccce5a9 
  src/master/validation.cpp f45f9e816bdaf6304794604570edbd68d5faf715 
  src/tests/master_validation_tests.cpp 4e7ce74edf0069b9317f869b299694a45e2a62f2 
  src/v1/resources.cpp 236fe17730918479a33314e51d14f3cc1679d432 


Diff: https://reviews.apache.org/r/60013/diff/11/

Changes: https://reviews.apache.org/r/60013/diff/10-11/


Testing
-------


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message