mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 60068: Updated the authorizer to look at the correct fields.
Date Wed, 14 Jun 2017 18:05:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60068/#review177929
-----------------------------------------------------------


Fix it, then Ship it!





src/authorizer/local/authorizer.cpp
Line 558 (original), 561 (patched)
<https://reviews.apache.org/r/60068/#comment251635>

    for extracting reservation principal above, you pulled it into a temp variable and did
a CHECK_SOME, whereas here you are directly doing a `.get()`. why the inconsistency?


- Vinod Kone


On June 14, 2017, 9:55 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60068/
> -----------------------------------------------------------
> 
> (Updated June 14, 2017, 9:55 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the authorizer to look at the correct fields.
> 
> 
> Diffs
> -----
> 
>   src/authorizer/local/authorizer.cpp 1f2a9902e88705cf412af834c127c3afe6d3bef4 
> 
> 
> Diff: https://reviews.apache.org/r/60068/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message