mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 60053: Revert "Disabled support for hierarchical roles".
Date Tue, 13 Jun 2017 19:36:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60053/#review177790
-----------------------------------------------------------



A description would have been nice for posterity. E.g. we're re-enabling the support for hierarchical
roles because we're planning to ship partial support (w/o quota?) in 1.4..? Seems a lot of
context is needed to understand this?

- Benjamin Mahler


On June 13, 2017, 6:08 p.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60053/
> -----------------------------------------------------------
> 
> (Updated June 13, 2017, 6:08 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Neil Conway.
> 
> 
> Bugs: MESOS-7505
>     https://issues.apache.org/jira/browse/MESOS-7505
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This reverts commit e0d8cc7c4ef7a0905044159ca47f64b0923e9788.
> 
> 
> Diffs
> -----
> 
>   src/common/roles.cpp 139ae87970d6830a934cc84b0786ece29328d452 
>   src/tests/master_allocator_tests.cpp a301c16fa52cd024dfc8f5f2fdc226810333ffb8 
>   src/tests/role_tests.cpp 03b6f7bd631850839b29b069ac63e7ef8841ad7c 
> 
> 
> Diff: https://reviews.apache.org/r/60053/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Michael Park
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message