mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Park <mp...@apache.org>
Subject Review Request 60021: Corrected the use of `toUnreserved()` to be more accurate.
Date Mon, 12 Jun 2017 18:46:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60021/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Bugs: MESOS-7655
    https://issues.apache.org/jira/browse/MESOS-7655


Repository: mesos


Description
-------

The simple change from `flatten()` to `toUnreserved()` needs to be updated to account for
reservation refinement.
When we look for resources to be reserved (for example, reserving 4 cpus for role `R`"), it
used to be sufficient
to simply look for unreserved versions of the resources (4 cpus, unreserved). Now, we need
to look for version
of the resources with the last reservation popped. Note that for the single reservation case,
the behavior
remains unchanged.


Diffs
-----

  src/common/resources.cpp f89f1aae7845f1e93dd5947de2e7a8e2bfce8bc4 
  src/master/http.cpp 1dcfe6ef00b0e3984deb79a511e665f638661323 
  src/v1/resources.cpp 24240eedc4b2747ca02998534437318c3396db4d 


Diff: https://reviews.apache.org/r/60021/diff/1/


Testing
-------


Thanks,

Michael Park


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message