mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 59873: Refactored `HealthChecker` to use `CheckerProcess`.
Date Thu, 08 Jun 2017 17:05:28 GMT


> On June 8, 2017, 4:33 p.m., Alexander Rukletsov wrote:
> > src/checks/health_checker.cpp
> > Lines 298-300 (original), 343-345 (patched)
> > <https://reviews.apache.org/r/59873/diff/2/?file=1744181#file1744181line404>
> >
> >     Here we should probably print `consecutiveFailures`, because a health check
may fail consecutively for various reasons.
> 
> Gastón Kleiman wrote:
>     We already print `consecutiveFailures`, see line 345 =)

I forgot "only" : ). I don't think we should print `message` here, but rather earlier and
have this method take no parameters. Imagine:
```
COMMAND health check for task 'a' failed 1 times consecutively: timed out after ...
COMMAND health check for task 'a' failed 2 times consecutively: Unexpected HTTP response code:
..
```
This can be misinterpreted as total 3 consecutive failures. Instead I asuggest the following:
```
COMMAND health check for task 'a' failed: timed out after ...
COMMAND health check for task 'a' failed 1 times consecutively
COMMAND health check for task 'a' failed: Unexpected HTTP response code: ..
COMMAND health check for task 'a' failed 2 times consecutively
```


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59873/#review177306
-----------------------------------------------------------


On June 7, 2017, 11:56 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59873/
> -----------------------------------------------------------
> 
> (Updated June 7, 2017, 11:56 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-7092
>     https://issues.apache.org/jira/browse/MESOS-7092
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `HealthChecker` now wraps a `CheckerProcess` and gets check status
> updates via a callback.
> 
> 
> Diffs
> -----
> 
>   src/checks/checker.cpp dcc3164f3b623de73bacf024ede95b40c48f7192 
>   src/checks/checker_process.hpp PRE-CREATION 
>   src/checks/checker_process.cpp PRE-CREATION 
>   src/checks/health_checker.hpp 25bf7e99bf5982fd7a6ff5012c231ff89fb7cb39 
>   src/checks/health_checker.cpp 9d8c8471caa05af3908d34315dbfed08a343c0f8 
> 
> 
> Diff: https://reviews.apache.org/r/59873/diff/2/
> 
> 
> Testing
> -------
> 
> Tests still pass on GNU/Linux.
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message