mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 59902: Improved health checks validations.
Date Thu, 08 Jun 2017 16:33:33 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59902/#review177320
-----------------------------------------------------------




src/checks/health_checker.cpp
Lines 388-391 (original), 388-391 (patched)
<https://reviews.apache.org/r/59902/#comment250854>

    I suggest we remove this altogether in favor of validation you introduce in this patch.


- Alexander Rukletsov


On June 8, 2017, 1:23 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59902/
> -----------------------------------------------------------
> 
> (Updated June 8, 2017, 1:23 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-6916
>     https://issues.apache.org/jira/browse/MESOS-6916
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added validation for the "general" fields, such as `timeout_seconds`.
> 
> 
> Diffs
> -----
> 
>   src/checks/health_checker.cpp 9d8c8471caa05af3908d34315dbfed08a343c0f8 
> 
> 
> Diff: https://reviews.apache.org/r/59902/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` still passes on GNU/Linux
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message