mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 59902: Improved health checks validations.
Date Wed, 07 Jun 2017 23:58:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59902/#review177258
-----------------------------------------------------------



Bad patch!

Reviews applied: [59902, 59873, 59872, 59871]

Failed command: python support/apply-reviews.py -n -r 59871

Error:
Traceback (most recent call last):
  File "support/apply-reviews.py", line 381, in <module>
    reviewboard()
  File "support/apply-reviews.py", line 360, in reviewboard
    apply_review()
  File "support/apply-reviews.py", line 126, in apply_review
    commit_patch()
  File "support/apply-reviews.py", line 225, in commit_patch
    shell(cmd, options['dry_run'])
  File "support/apply-reviews.py", line 111, in shell
    error_code = subprocess.call(command, stderr=subprocess.STDOUT, shell=True)
  File "C:\Python27\lib\subprocess.py", line 168, in call
    return Popen(*popenargs, **kwargs).wait()
  File "C:\Python27\lib\subprocess.py", line 390, in __init__
    errread, errwrite)
  File "C:\Python27\lib\subprocess.py", line 610, in _execute_child
    args = '{} /c "{}"'.format (comspec, args)
UnicodeEncodeError: 'ascii' codec can't encode character u'\xf3' in position 25: ordinal not
in range(128)

Full log: http://mesos-winbot.westus.cloudapp.azure.com/logs/75/console

- Mesos Reviewbot Windows


On June 7, 2017, 4:56 p.m., Gastón Kleiman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59902/
> -----------------------------------------------------------
> 
> (Updated June 7, 2017, 4:56 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Vinod Kone.
> 
> 
> Bugs: MESOS-6916 and MESOS-7092
>     https://issues.apache.org/jira/browse/MESOS-6916
>     https://issues.apache.org/jira/browse/MESOS-7092
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added validation for the "general" fields, such as `timeout_seconds`.
> 
> 
> Diffs
> -----
> 
>   src/checks/health_checker.cpp 9d8c8471caa05af3908d34315dbfed08a343c0f8 
> 
> 
> Diff: https://reviews.apache.org/r/59902/diff/1/
> 
> 
> Testing
> -------
> 
> `make check` still passes on GNU/Linux
> 
> 
> Thanks,
> 
> Gastón Kleiman
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message