mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 59829: Removed custom C++ style guide recommendation regarding lambda captures.
Date Tue, 06 Jun 2017 07:41:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59829/
-----------------------------------------------------------

Review request for mesos, Michael Park and Till Toenshoff.


Repository: mesos


Description
-------

Our C++ style guide is based on the Google C++ style guide which
already gives rather detailed recommendations[^1], e.g., on how to
capture. In particular, it recommends capture by value and goes into
some detail on the caveats of capturing pointer values.

Our customization on top of the Google style guide does not add much,
but while pointing out the issues of capturing by reference, misses
that pointers captured by value bring about similar issues.

[^1]:
https://google.github.io/styleguide/cppguide.html#Lambda_expressions


Diffs
-----

  docs/c++-style-guide.md 1fec9a76ce3c7193c75ff0ec226ff91cdb2adf79 


Diff: https://reviews.apache.org/r/59829/diff/1/


Testing
-------

Examined rendered site.


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message