mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 59320: Added test case for agent re-registration.
Date Wed, 31 May 2017 20:35:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59320/
-----------------------------------------------------------

(Updated May 31, 2017, 8:35 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
-------

Improve comment, try enabling test on Windows.


Repository: mesos


Description
-------

Add an explanatory comment and a test case for a particular case in the
master's logic for handling agent re-registration.


Diffs (updated)
-----

  src/master/master.cpp a5376f9fc3c3c6c72b22cfd36ec56a1de0d03a3a 
  src/tests/partition_tests.cpp 62a84f797201ccd18b71490949e3130d2b9c3668 


Diff: https://reviews.apache.org/r/59320/diff/3/

Changes: https://reviews.apache.org/r/59320/diff/2-3/


Testing
-------

`make check`

Checked that if you add `CHECK_NOTNULL(framework)` to the master code (circa the newly added
comment), the incorrect `CHECK` is triggered by this test case (but not by any existing test
cases).


Thanks,

Neil Conway


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message