mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 59219: Removed logic for handling missing FrameworkID in ExecutorInfo.
Date Tue, 30 May 2017 23:39:30 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59219/#review176394
-----------------------------------------------------------


Ship it!





src/master/master.cpp
Line 7564 (original), 7564 (patched)
<https://reviews.apache.org/r/59219/#comment249764>

    Maybe a comment that the master validates this when tasks are launched?


- Benjamin Mahler


On May 16, 2017, 8:36 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59219/
> -----------------------------------------------------------
> 
> (Updated May 16, 2017, 8:36 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6977
>     https://issues.apache.org/jira/browse/MESOS-6977
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The master will inject missing `FrameworkID`s into `ExecutorInfo` since
> Mesos 0.23 (see MESOS-2290), so it should be safe to assume it is always
> set.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad 
> 
> 
> Diff: https://reviews.apache.org/r/59219/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message