mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kevin Klues <klue...@gmail.com>
Subject Re: Review Request 59177: CLI: Added Config class to manage the config file.
Date Mon, 29 May 2017 12:37:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59177/#review176264
-----------------------------------------------------------


Ship it!




I am adding the JIRA issue, changing the summary slightly, and separating this out into two
separate patches before committing.


src/cli_new/bin/main.py
Lines 62-63 (patched)
<https://reviews.apache.org/r/59177/#comment249637>

    I am going to separate this change out into its own commit, but otherwise, this patch
looks good now.


- Kevin Klues


On May 29, 2017, 12:36 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59177/
> -----------------------------------------------------------
> 
> (Updated May 29, 2017, 12:36 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Bugs: MESOS-7582
>     https://issues.apache.org/jira/browse/MESOS-7582
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This new class simplifies the management of the configuration file
> given by the user; it loads the TOML file on initialization and
> has one method for each element that the user can set.
> 
> This new class and its associated content is also given to the plugins
> at initialization so that they can read the user configuration and use
> it.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/bin/main.py 397c120eaaa8f21030dedb1ed552e65c704ee7da 
>   src/cli_new/bin/settings.py 0ef07cc67e8020be0424e939e5b19475fb998ac7 
>   src/cli_new/lib/cli/__init__.py f4fc3f18af5641a4a87143adaba81e62334ccffb 
>   src/cli_new/lib/cli/config.py PRE-CREATION 
>   src/cli_new/lib/cli/plugins/base.py c10d70fb1b3d232008dd908ea747ec6782a9d47e 
>   src/cli_new/lib/cli/plugins/config/main.py d95a36f4a66c66b4477c6816b7fa5a721f9212f7

>   src/cli_new/lib/cli/util.py 27c4f17e4b75f63f2fb31f0ad27a464227d29448 
> 
> 
> Diff: https://reviews.apache.org/r/59177/diff/2/
> 
> 
> Testing
> -------
> 
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message