mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 59018: Supported Image::Secret in docker URI fetcher plugin.
Date Tue, 23 May 2017 20:06:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59018/#review175836
-----------------------------------------------------------


Fix it, then Ship it!





src/uri/fetchers/docker.cpp
Lines 538 (patched)
<https://reviews.apache.org/r/59018/#comment249171>

    s/The secret value/`data`/


- Vinod Kone


On May 22, 2017, 6:04 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59018/
> -----------------------------------------------------------
> 
> (Updated May 22, 2017, 6:04 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff,
and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
>     https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Supported Image::Secret in docker URI fetcher plugin.
> 
> 
> Diffs
> -----
> 
>   src/uri/fetchers/docker.cpp 8aab169f0628ad540654a7b6c15efbc282f5e940 
> 
> 
> Diff: https://reviews.apache.org/r/59018/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> Manually tested using mesos-execute with task group. Verified that pulling separate private
image from different registries using different image secrets works correctly.
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message