mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <>
Subject Re: Review Request 59195: Ensure that allocator can be updated before committing changes.
Date Wed, 17 May 2017 02:00:57 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 17, 2017, 2 a.m.)

Review request for mesos, James Peach and Jiang Yan Xu.


Check if `slave.allocated.apply()` can be done before iterating through individual operations.

Bugs: MESOS-7308

Repository: mesos

Description (updated)

In addition to `apply()` on `offeredResources`, we ensure all operations
can be applied on `slave.allocated`. It is is so because certain
operations require that they are applicable to the agent's allocated
resources as a whole.
Note that we return a failed future on any error.We do not
modify the state of the allocator if any of the operations fail.

Diffs (updated)

  include/mesos/allocator/allocator.hpp dc34a1b6f0c2bdf0d653bd53394364cfa9873ca7 
  src/master/allocator/mesos/allocator.hpp 119b461136123229f85ed3c3cfd41137974a6b9b 
  src/master/allocator/mesos/hierarchical.hpp 123f97cf495bff0f822838e09df0d88818f04da6 
  src/master/allocator/mesos/hierarchical.cpp b75ed9a20a9a42f958cebbacd91e5e15b0d21394 
  src/tests/allocator.hpp 4ea722491f63f5ceda5a47228aafddc020f643b0 
  src/tests/hierarchical_allocator_tests.cpp 08180b9975869de328f0c095dd3cddf0c84fbecf 




All tests passed.


Anindya Sinha

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message