mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Neil Conway <neil.con...@gmail.com>
Subject Re: Review Request 59219: Removed code for old agents in agent re-registration logic.
Date Tue, 16 May 2017 20:31:51 GMT


> On May 12, 2017, 9:40 p.m., Benjamin Mahler wrote:
> > src/master/master.cpp
> > Lines 7564-7573 (original), 7564 (patched)
> > <https://reviews.apache.org/r/59219/diff/1/?file=1716308#file1716308line7564>
> >
> >     Hm.. this seems to refer to the scheduler driver rather than a slave version?

Ah, true -- the comment's wording confused me. This validation was moved to the master 2 years
ago: https://reviews.apache.org/r/30952/

Since the master has added missing `FrameworkID`s to `Launch` messages since Mesos 0.23, it
should be safe to assume the `FrameworkID` is set in `ExecutorInfo`.


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59219/#review174860
-----------------------------------------------------------


On May 11, 2017, 11:32 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59219/
> -----------------------------------------------------------
> 
> (Updated May 11, 2017, 11:32 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-6977
>     https://issues.apache.org/jira/browse/MESOS-6977
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> 0.x agents are no longer supported.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad 
> 
> 
> Diff: https://reviews.apache.org/r/59219/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message