mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 59177: CLI: Added Config class to manage the config file.
Date Thu, 11 May 2017 18:09:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59177/#review174702
-----------------------------------------------------------



Patch looks great!

Reviews applied: [59177]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose'
ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On May 11, 2017, 1:23 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59177/
> -----------------------------------------------------------
> 
> (Updated May 11, 2017, 1:23 p.m.)
> 
> 
> Review request for mesos and Kevin Klues.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This new class simplifies the management of the configuration file
> given by the user; it loads the TOML file on initialization and
> has one method for each element that the user can set.
> 
> 
> Diffs
> -----
> 
>   src/cli_new/bin/main.py 397c120eaaa8f21030dedb1ed552e65c704ee7da 
>   src/cli_new/bin/settings.py 0ef07cc67e8020be0424e939e5b19475fb998ac7 
>   src/cli_new/lib/cli/__init__.py f4fc3f18af5641a4a87143adaba81e62334ccffb 
>   src/cli_new/lib/cli/config.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59177/diff/1/
> 
> 
> Testing
> -------
> 
> Tested manually, PEP8 and Pylint used to make sure that the code style is correct.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message