mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Review Request 59116: Windows: Updated `support/windows-build.bat`.
Date Wed, 10 May 2017 20:40:36 GMT

This is an automatically generated e-mail. To reply, visit:

Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.

Bugs: MESOS-7343

Repository: mesos

Description (updated)

It now understands the environment variable `CMAKE_GENERATOR` so that
users can change the generator; the default is still Visual Studio 14.

Direct usage of `msbuild` was replaced with `cmake --build`.

We now build `mesos-tests` in the same pattern as `stout-tests` and
`libprocess-tests`. If admin priveleges are missing, we skip running the
tests, but still proceed to build the general target.

We set the CMake toolset instead of an environment variable for

Diffs (updated)

  support/windows-build.bat 88e177ced912b61f8169b58a50d1cf6ba0c4c0c7 


Testing (updated)

Built and tested script with clean build on Windows.


Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message