mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Re: Review Request 59156: CMake: Use `list(APPEND x ...)` over `set(x ${x} ...)`.
Date Wed, 10 May 2017 20:34:05 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 10, 2017, 8:34 p.m.)

Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, and Li Li.

Bugs: MESOS-7497

Repository: mesos


This removes a CMake anti-pattern where `set` was used to append to a
variable, instead of the more explicit `list(APPEND)` or
`string(APPEND)` alternatives.


  cmake/CompilationConfigure.cmake 7b2669f0c54abf9b5e0fd60f8af01e97e1f0f86a 



Re-configured and built on Windows.

NOTE: This syntax should be preferred going forward. There are more instances of the anti-pattern
the setting of source files, but we'll take care of it in a later patch to avoid too much


Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message