mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 59015: Implemented passing docker config to URIs.
Date Wed, 10 May 2017 12:24:55 GMT


> On May 8, 2017, 5:29 p.m., Vinod Kone wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp
> > Lines 270-271 (patched)
> > <https://reviews.apache.org/r/59015/diff/1/?file=1709137#file1709137line270>
> >
> >     am i reading it correctly that `None` represents principal here? i thought both
username and password are inside the docker config, so i'm a bit confused.

This is fixed by changing the URI fetcher's interface.


- Gilbert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59015/#review174256
-----------------------------------------------------------


On May 4, 2017, 4:22 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59015/
> -----------------------------------------------------------
> 
> (Updated May 4, 2017, 4:22 p.m.)
> 
> 
> Review request for mesos, Adam B, Chun-Hung Hsiao, Jie Yu, Kapil Arya, Till Toenshoff,
and Vinod Kone.
> 
> 
> Bugs: MESOS-7088
>     https://issues.apache.org/jira/browse/MESOS-7088
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Implemented passing docker config to URIs.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 6db788dd0c582deadf3e91c4d21bb9c20cf94e6b

>   src/uri/schemes/docker.hpp 527c7e4ba6f1b505543655cca870e39b93a5266e 
> 
> 
> Diff: https://reviews.apache.org/r/59015/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message