mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <>
Subject Re: Review Request 58952: Added test helper to disambiguate allocator method call.
Date Tue, 09 May 2017 14:46:19 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 9, 2017, 4:46 p.m.)

Review request for mesos, Benjamin Mahler, Jie Yu, and Jan Schlicht.



Summary (updated)

Added test helper to disambiguate allocator method call.

Bugs: MESOS-7388

Repository: mesos


In a subsequent commit we will transitionally introduce a second
'addFramework' allocator method overload where the 'used' set refers
to 'ResourceProviderID's instead of 'SlaveID's. Introduce a test
helper here to remove a future ambiguity when an empty set '{}' is
passed. We introduce this in a separate patch so that this change can
more easily be removed one the old allocator method is removed and the
ambiguity vanishes.

Diffs (updated)

  src/tests/hierarchical_allocator_tests.cpp 08180b9975869de328f0c095dd3cddf0c84fbecf 




`make check`


Benjamin Bannier

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message