mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Vinod Kone <vinodk...@gmail.com>
Subject Re: Review Request 59000: Added environment secret isolator.
Date Tue, 09 May 2017 00:03:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59000/#review174246
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.cpp
Lines 226 (patched)
<https://reviews.apache.org/r/59000/#comment247369>

    should this be "environment/secret" instead? i'm assuming there might be other env based
isolators in the future.



src/slave/containerizer/mesos/containerizer.cpp
Lines 1460 (patched)
<https://reviews.apache.org/r/59000/#comment247370>

    s/have been/should have been/



src/slave/containerizer/mesos/isolators/environment_secret.cpp
Lines 98 (patched)
<https://reviews.apache.org/r/59000/#comment247374>

    s/environment/Enviornment/
    
    log the variable name?



src/slave/containerizer/mesos/isolators/environment_secret.cpp
Lines 107 (patched)
<https://reviews.apache.org/r/59000/#comment247375>

    log variable name.



src/slave/containerizer/mesos/isolators/environment_secret.cpp
Lines 122 (patched)
<https://reviews.apache.org/r/59000/#comment247376>

    can you use `collect` instead?



src/tests/containerizer/environment_secret_isolator_tests.cpp
Lines 52 (patched)
<https://reviews.apache.org/r/59000/#comment247377>

    kill the comment.



src/tests/containerizer/environment_secret_isolator_tests.cpp
Lines 76 (patched)
<https://reviews.apache.org/r/59000/#comment247378>

    no need for `Times(1)`


- Vinod Kone


On May 8, 2017, 10:19 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59000/
> -----------------------------------------------------------
> 
> (Updated May 8, 2017, 10:19 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added environment secret isolator.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 40d921ee7026f5ac47efbf0243e1cafab57825f9 
>   src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
>   src/launcher/executor.cpp b05f73e539c22d4d40f07df76168a06373b818d4 
>   src/slave/containerizer/mesos/containerizer.cpp 58ab74571fb14c6dbb1907151dc421f93e324bb5

>   src/slave/containerizer/mesos/isolators/environment_secret.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/environment_secret.cpp PRE-CREATION 
>   src/tests/CMakeLists.txt 9f2af9cdd1cf50485f4cd84ce67bcceba64b9328 
>   src/tests/containerizer/environment_secret_isolator_tests.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59000/diff/4/
> 
> 
> Testing
> -------
> 
> Added a new test and ran `make check`.
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message