mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Review Request 59061: Fixed provisioner recover blockage by non-existing rootfses dir.
Date Mon, 08 May 2017 19:51:26 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59061/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao, Jie Yu, Michael Park, Neil Conway, and Vinod Kone.


Bugs: MESOS-7471
    https://issues.apache.org/jira/browse/MESOS-7471


Repository: mesos


Description
-------

In provisioner recover, when listing the container rootfses, it is
possible that the 'rootfses' dir does not exist. Because a possible
race between the provisioner destroy and the agent restart. For
instance, while the provisioner is destroying the container dir the
agent restarts. Due to os::rmdir() is recursive by traversing the
FTS tree, it is possible that 'rootfses' dir is removed but the
others (e.g., scratch dir) are not.

Currently, we are returning an error if the 'rootfses' dir does not
exist, which blocks the agent from recovery. We should skip it if
'rootfses' does not exist.


Diffs
-----

  src/slave/containerizer/mesos/provisioner/paths.cpp d2de98b66b7cf8331e82c31d0602dfe7e77d2130



Diff: https://reviews.apache.org/r/59061/diff/1/


Testing
-------

make check


Thanks,

Gilbert Song


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message