mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <>
Subject Re: Review Request 58720: CLI: Extended the unit test infrastructure.
Date Fri, 05 May 2017 17:02:42 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated May 5, 2017, 5:02 p.m.)

Review request for mesos and Kevin Klues.


Constants moved to be accessible from the CLI and not just the tests.

Bugs: MESOS-7283

Repository: mesos


This infrastructure includes the ability to bring up a test cluster to
run the CLI against. Future unit tests will use this infrastructure to
test their commands against a running mesos cluster. The tests require
some binaries created when building Mesos.

Diffs (updated)

  src/cli_new/lib/cli/ f4fc3f18af5641a4a87143adaba81e62334ccffb 
  src/cli_new/lib/cli/ PRE-CREATION 
  src/cli_new/lib/cli/tests/ PRE-CREATION 
  src/cli_new/lib/cli/tests/ PRE-CREATION 
  src/cli_new/lib/cli/tests/ PRE-CREATION 
  src/cli_new/pip-requirements.txt 28613e56a5c6d5c7606a7e58d6125b0c34748e83 
  src/cli_new/tests/ dff5d48b0ddae87960a78f9d05e4ae597912f1f6 




PEP8 and Pylint used to make sure that the code style is correct. Manuel test:

$ cd src/cli_new
$ ./bootstrap
$ source activate

(mesos-cli) $ mesos-cli-tests


Armand Grillet

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message