mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anindya Sinha <anindya_si...@apple.com>
Subject Re: Review Request 57817: Offers not sent for deactivated roles as indicated in `SUBSCRIBE`.
Date Fri, 05 May 2017 00:34:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57817/
-----------------------------------------------------------

(Updated May 5, 2017, 12:34 a.m.)


Review request for mesos, James Peach, Vinod Kone, and Jiang Yan Xu.


Changes
-------

Modifications based on discussion in Slack.


Summary (updated)
-----------------

Offers not sent for deactivated roles as indicated in `SUBSCRIBE`.


Bugs: MESOS-7015
    https://issues.apache.org/jira/browse/MESOS-7015


Repository: mesos


Description (updated)
-------

If the framework indicates a subset of roles to be deactivated, the
allocator does not offer resources for those roles to such frameworks.
In addition, the master validates the deactivated roles to be a
subset of all the roles being (re)registered by the framework.


Diffs (updated)
-----

  src/common/protobuf_utils.hpp be2325f05b81b847fa592eff65175cbc99764fd6 
  src/common/protobuf_utils.cpp 3fcaf786b29a00f003c10b0f1614a2c7eddc725d 
  src/master/allocator/mesos/hierarchical.hpp 123f97cf495bff0f822838e09df0d88818f04da6 
  src/master/allocator/mesos/hierarchical.cpp b75ed9a20a9a42f958cebbacd91e5e15b0d21394 
  src/master/master.cpp 4e7a161f431624bd78d3e9032eb8587687149cad 
  src/tests/hierarchical_allocator_tests.cpp ebc4868a6b7e2a04cc202a74a4633969ade40aca 


Diff: https://reviews.apache.org/r/57817/diff/6/

Changes: https://reviews.apache.org/r/57817/diff/5-6/


Testing
-------

All tests passed.


Thanks,

Anindya Sinha


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message